feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r431313236
########## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ########## @@ -379,6 +380,22 @@ private static MetadataResponse prepareMetadataResponse(Cluster cluster, Errors MetadataResponse.AUTHORIZED_OPERATIONS_OMITTED); } + private static DescribeGroupsResponseData prepareDescribeGroupsResponseData(String groupId, List<String> groupInstances, Review comment: Fixed ########## File path: core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala ########## @@ -1017,47 +1017,70 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegrationTest { assertTrue(0 == list1.errors().get().size()) assertTrue(0 == list1.valid().get().size()) val testTopicName = "test_topic" + val testTopicName1 = testTopicName + "1" + val testTopicName2 = testTopicName + "2" val testNumPartitions = 2 - client.createTopics(Collections.singleton( - new NewTopic(testTopicName, testNumPartitions, 1.toShort))).all().get() - waitForTopics(client, List(testTopicName), List()) + + client.createTopics(util.Arrays.asList(new NewTopic(testTopicName, testNumPartitions, 1.toShort), Review comment: Fixed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org