[GitHub] [kafka] rajinisivaram commented on a change in pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

[GitBox]

rajinisivaram commented on a change in pull request #8705:
URL: https://github.com/apache/kafka/pull/8705#discussion_r431862643



##########
File path: core/src/test/scala/unit/kafka/network/SocketServerTest.scala
##########
@@ -1807,6 +1817,7 @@ class SocketServerTest {
           currentPollValues ++= newValues
         } else
           deferredValues ++= newValues
+        newValues.clear()

Review comment:
       ah, I refactored a bit to clear the original buffer in each case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org