[GitHub] [kafka] rajinisivaram commented on a change in pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

[GitBox]

rajinisivaram commented on a change in pull request #8705:
URL: https://github.com/apache/kafka/pull/8705#discussion_r431698413



##########
File path: core/src/test/scala/unit/kafka/network/SocketServerTest.scala
##########
@@ -1807,6 +1817,7 @@ class SocketServerTest {
           currentPollValues ++= newValues
         } else
           deferredValues ++= newValues
+        newValues.clear()

Review comment:
       We return `minPerPoll` results together, so the current values are 
cleared and then populated as necessary. The code is now in the same place, so 
hopefully that is clearer.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org