bellemare commented on a change in pull request #8764:
URL: https://github.com/apache/kafka/pull/8764#discussion_r437560085



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableKTableForeignKeyJoinScenarioTest.java
##########
@@ -243,17 +244,17 @@ private void validateTopologyCanProcessData(final 
StreamsBuilder builder) {
         final String safeTestName = safeUniqueTestName(getClass(), testName);
         config.setProperty(StreamsConfig.APPLICATION_ID_CONFIG, "dummy-" + 
safeTestName);
         config.setProperty(StreamsConfig.BOOTSTRAP_SERVERS_CONFIG, "dummy");
-        config.setProperty(StreamsConfig.DEFAULT_KEY_SERDE_CLASS_CONFIG, 
Serdes.StringSerde.class.getName());
+        config.setProperty(StreamsConfig.DEFAULT_KEY_SERDE_CLASS_CONFIG, 
Serdes.IntegerSerde.class.getName());
         config.setProperty(StreamsConfig.DEFAULT_VALUE_SERDE_CLASS_CONFIG, 
Serdes.StringSerde.class.getName());
         config.setProperty(StreamsConfig.STATE_DIR_CONFIG, 
TestUtils.tempDirectory().getAbsolutePath());
         try (final TopologyTestDriver topologyTestDriver = new 
TopologyTestDriver(builder.build(), config)) {
-            final TestInputTopic<String, String> aTopic = 
topologyTestDriver.createInputTopic("A", new StringSerializer(), new 
StringSerializer());
-            final TestInputTopic<String, String> bTopic = 
topologyTestDriver.createInputTopic("B", new StringSerializer(), new 
StringSerializer());
-            final TestOutputTopic<String, String> output = 
topologyTestDriver.createOutputTopic("output", new StringDeserializer(), new 
StringDeserializer());
-            aTopic.pipeInput("a1", "b1-alpha");
-            bTopic.pipeInput("b1", "beta");
-            final Map<String, String> x = output.readKeyValuesToMap();
-            assertThat(x, is(Collections.singletonMap("a1", 
"(b1-alpha,(b1-alpha,beta))")));
+            final TestInputTopic<Integer, String> aTopic = 
topologyTestDriver.createInputTopic("A", new IntegerSerializer(), new 
StringSerializer());
+            final TestInputTopic<Integer, String> bTopic = 
topologyTestDriver.createInputTopic("B", new IntegerSerializer(), new 
StringSerializer());
+            final TestOutputTopic<Integer, String> output = 
topologyTestDriver.createOutputTopic("output", new IntegerDeserializer(), new 
StringDeserializer());
+            aTopic.pipeInput(1, "1-alpha");
+            bTopic.pipeInput(1, "beta");

Review comment:
       I swear I know how to read... T_T




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to