mimaison commented on a change in pull request #8604:
URL: https://github.com/apache/kafka/pull/8604#discussion_r448979596
##########
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##########
@@ -309,7 +308,7 @@ object ConsoleConsumer extends Logging {
formatterArgs.setProperty(ConsumerConfig.VALUE_DESERIALIZER_CLASS_CONFIG,
valueDeserializer)
}
- formatter.init(formatterArgs)
+ formatter.configure(formatterArgs.asScala.asJava)
Review comment:
This trick is used in a couple of other places. I took a quick look at
switching to a `Map` directly but it's used in a bunch of places so ended up
being a larger change. I'd prefer keeping this PR focussed on the new formatter
and maybe do some refactoring in a follow up PR. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
