mimaison commented on a change in pull request #8604:
URL: https://github.com/apache/kafka/pull/8604#discussion_r448980591
##########
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##########
@@ -466,7 +465,9 @@ class DefaultMessageFormatter extends MessageFormatter {
var keyDeserializer: Option[Deserializer[_]] = None
var valueDeserializer: Option[Deserializer[_]] = None
- override def init(props: Properties): Unit = {
+ override def configure(configs: Map[String, _]): Unit = {
+ val props = new java.util.Properties()
+ configs.asScala.foreach { case (key, value) => props.put(key,
value.toString) }
Review comment:
I initially was doing this but this forces casting the value to strings
everywhere due to the type of the Map here `[String, _]`. Keeping the
`Properties` object turned out way simpler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
