hachikuji commented on a change in pull request #8891:
URL: https://github.com/apache/kafka/pull/8891#discussion_r450517031



##########
File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
##########
@@ -962,22 +963,18 @@ object ReassignPartitionsCommand extends Logging {
     verifyBrokerIds(adminClient, proposedParts.values.flatten.toSet)
     val currentParts = getReplicaAssignmentForPartitions(adminClient, 
proposedParts.keySet.toSet)
     println(currentPartitionReplicaAssignmentToString(proposedParts, 
currentParts))
-    if (interBrokerThrottle >= 0 || logDirThrottle >= 0) {
+
+    if (interBrokerThrottle > 0 || logDirThrottle > 0) {

Review comment:
       I'll revert this change. I thought I had noticed an inconsistency, but 
maybe it was just the comment in the command description.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to