cmccabe commented on a change in pull request #8863:
URL: https://github.com/apache/kafka/pull/8863#discussion_r450503568
##########
File path: tools/src/main/java/org/apache/kafka/trogdor/agent/Agent.java
##########
@@ -92,6 +93,8 @@
private final Time time;
+ final TrogdorMetrics trogdorMetrics;
Review comment:
It doesn't seem right for the Agent to share the same metrics with the
Coordinator. For example, `active-agents-count` is meaningless on the agent,
since it doesn't know how many other agents there are. We should probably
clarify this in the KIP as well (metrics that are not relevant to the agent are
not included there).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
