rajinisivaram commented on a change in pull request #8986:
URL: https://github.com/apache/kafka/pull/8986#discussion_r451498688
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##########
@@ -460,15 +463,21 @@ boolean joinGroupIfNeeded(final Timer timer) {
exception instanceof IllegalGenerationException ||
exception instanceof MemberIdRequiredException)
continue;
- else if (!future.isRetriable())
- throw exception;
-
- timer.sleep(rebalanceConfig.retryBackoffMs);
+ else {
+ handleFailure(future, timer);
+ }
}
}
return true;
}
+ protected void handleFailure(RequestFuture<?> future, Timer timer) {
+ if (future.isRetriable() || future.exception() instanceof
AuthorizationException)
Review comment:
@abbccdda Thanks for the review. The instance we saw was an
authorization failure for groups, but since I was fixing handling of all
responses, I used `AuthorizationException` in the check since we want to ensure
we backoff for topic authorization exceptions too. We already backoff for
`RetriableException` and I haven't changed that behaviour, this PR addresses
exceptions that are not subclasses of `RetriableException`. Perhaps just
updating `AuthorizationException` as is currently done in the PR is sufficient?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
