ijuma commented on a change in pull request #8657:
URL: https://github.com/apache/kafka/pull/8657#discussion_r452634516
##########
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##########
@@ -239,9 +239,13 @@ class GroupMetadataManager(brokerId: Int,
}
}
+ /**
+ * @return Returning a map of successfully appended topic partitions and a
flag indicting whether the HWM has been
+ * incremented. The caller ought to complete delayed requests for
those returned partitions.
+ */
def storeGroup(group: GroupMetadata,
groupAssignment: Map[String, Array[Byte]],
- responseCallback: Errors => Unit): Unit = {
+ responseCallback: Errors => Unit): Map[TopicPartition,
LeaderHWChange] = {
Review comment:
It's weird to have a method that invokes a callback and returns a
result. Do we need both? We have a number of other methods that do something
similar. It would be good to reconsider that as it's difficult to reason about
usage in such cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
