vvcephei commented on a change in pull request #8994:
URL: https://github.com/apache/kafka/pull/8994#discussion_r453034571
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -95,7 +96,7 @@
* | | Assigned (3)| <----+
* | +-----+-------+ |
* | | |
- * | | |
+ * | |--------------+
Review comment:
Ah, sorry, I didn't see this follow-up question.
It's here:
https://github.com/apache/kafka/blob/568dceb5f61c71428432d23d947c5f9b29fb7bfb/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java#L657
I thought about it, but it seemed to be in violation of the whole idea of
having a specified state machine. I.e., saying "`if not running,
setState(running)`" is literally the same thing as saying that self-transitions
are allowed. So why not just say that self-transitions are allowed (explicitly
instead of implicitly)?
Anyway, that's what I was thinking; no guarantee that it makes sense ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
