mjsax commented on a change in pull request #8994:
URL: https://github.com/apache/kafka/pull/8994#discussion_r453070214
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -95,7 +96,7 @@
* | | Assigned (3)| <----+
* | +-----+-------+ |
* | | |
- * | | |
+ * | |--------------+
Review comment:
I agree with the sentiment. However, our overall patterns is to
disallowed self-transitions, ie, this pattern is applied throughout all other
code. IMHO, I might be better to stick with one pattern. Thus, if we think we
should allow self-transitions, we might want to do it for all states and update
the code throughout accordingly. Begin in a "mixed mode" seems suboptimal.
Of course this would be follow up work. And frankly I am not sure if it
would buy us much at this point?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
