mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r458481626
##########
File path: docs/upgrade.html
##########
@@ -23,8 +23,8 @@ <h5><a id="upgrade_270_notable"
href="#upgrade_270_notable">Notable changes in 2
<ul>
<li>The configuration parameter <code>retries</code> is deprecated for the
producer, admin, and Kafka Streams clients
via <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-572%3A+Improve+timeouts+and+retries+in+Kafka+Streams";>KIP-572</a>.
- You should use the producer's <code>delivery.timeout.ms</code>,
admin's <code>default.api.timeout.ms</code>, and
- Kafka Streams' new <code>task.timeout.ms</code> parameters instead.
+ You should use the producer's <code>delivery.timeout.ms</code> and
<code>max.block.ms</code>, admin's
Review comment:
As above.
##########
File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
##########
@@ -357,7 +357,7 @@
/** {@code commit.interval.ms} */
@SuppressWarnings("WeakerAccess")
public static final String COMMIT_INTERVAL_MS_CONFIG =
"commit.interval.ms";
- private static final String COMMIT_INTERVAL_MS_DOC = "The frequency with
which to save the position of the processor." +
+ private static final String COMMIT_INTERVAL_MS_DOC = "The frequency in
milliseconds with which to save the position of the processor." +
Review comment:
Same fixes as in the docs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
