mjsax commented on a change in pull request #9047:
URL: https://github.com/apache/kafka/pull/9047#discussion_r458482045
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##########
@@ -58,30 +60,33 @@
* of Global State Stores. There is only ever 1 instance of this class per
Application Instance.
*/
public class GlobalStateManagerImpl implements GlobalStateManager {
+ private final static long NO_DEADLINE = -1L;
+
private final Logger log;
+ private final Time time;
private final Consumer<byte[], byte[]> globalConsumer;
private final File baseDir;
private final StateDirectory stateDirectory;
private final Set<String> globalStoreNames = new HashSet<>();
private final FixedOrderMap<String, Optional<StateStore>> globalStores =
new FixedOrderMap<>();
private final StateRestoreListener stateRestoreListener;
private InternalProcessorContext globalProcessorContext;
- private final int retries;
- private final long retryBackoffMs;
private final Duration pollTime;
+ private final long taskTimeoutMs;
private final Set<String> globalNonPersistentStoresTopics = new
HashSet<>();
private final OffsetCheckpoint checkpointFile;
private final Map<TopicPartition, Long> checkpointFileCache;
private final Map<String, String> storeToChangelogTopic;
private final List<StateStore> globalStateStores;
- @SuppressWarnings("deprecation") // TODO: remove in follow up PR when
`RETRIES` is removed
Review comment:
This PR fixed 3 TODOs form the first PR. (The other two are in the test
-- also added a comment to the original PR that links to this PR as reference.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
