dajac commented on a change in pull request #9060:
URL: https://github.com/apache/kafka/pull/9060#discussion_r459582710
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##########
@@ -96,13 +104,15 @@ public InternalTopicManager(final Admin adminClient, final
StreamsConfig streams
// have existed with the expected number of partitions, or some create
topic returns fatal errors.
log.debug("Starting to validate internal topics {} in partition
assignor.", topics);
- int remainingRetries = retries;
+ long currentWallClockMs = time.milliseconds();
+ final long deadlineMs = currentWallClockMs + retryTimeoutMs;
Review comment:
That's right. I misread the default value of `max.poll.interval.ms`, too
many zeros for my eyes ;). The default works fine then. Do we want to protect
ourselves if the user changes the default? Or shall we just call out that
`api.default.timeout.ms` should be lower than `max.poll.interval.ms` somewhere?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
