mjsax commented on a change in pull request #9060:
URL: https://github.com/apache/kafka/pull/9060#discussion_r464759130
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java
##########
@@ -71,21 +73,20 @@
private final String topic2 = "test_topic_2";
private final String topic3 = "test_topic_3";
private final List<Node> singleReplica =
Collections.singletonList(broker1);
- private final int numRetries = 1;
private String threadName;
private MockAdminClient mockAdminClient;
private InternalTopicManager internalTopicManager;
- @SuppressWarnings("deprecation") // TODO revisit in follow up PR
private final Map<String, Object> config = new HashMap<String, Object>() {
{
put(StreamsConfig.APPLICATION_ID_CONFIG, "app-id");
put(StreamsConfig.BOOTSTRAP_SERVERS_CONFIG, broker1.host() + ":" +
broker1.port());
put(StreamsConfig.REPLICATION_FACTOR_CONFIG, 1);
put(StreamsConfig.producerPrefix(ProducerConfig.BATCH_SIZE_CONFIG), 16384);
- put(StreamsConfig.adminClientPrefix(StreamsConfig.RETRIES_CONFIG),
numRetries);
+
put(StreamsConfig.consumerPrefix(ConsumerConfig.MAX_POLL_INTERVAL_MS_CONFIG),
100);
Review comment:
In this PR, we change the "deadline" in the group leader to
create/verify all internal topics from "counting retries" to a timeout of
`max.poll.interval.ms / 2` and we reduce the default of 5 minutes to speed up
this test.
cf
https://github.com/apache/kafka/pull/9060/files#diff-d3963e433c59b08688bb4481faa20e97R79
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
