mjsax commented on pull request #9060: URL: https://github.com/apache/kafka/pull/9060#issuecomment-668357683
Updated. Call for review @abbccdda > Also, do we have new unit test coverage for the changes? We did not really change much, only switching from `retries` to a "timeout" and thus existing unit tests (that I updated accordingly, eg, different configs and/or different exception type) should be sufficient? The only other thing is the new error code and I just added 2 unit tests for this case. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
