[ 
https://issues.apache.org/jira/browse/KAFKA-10410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185367#comment-17185367
 ] 

Guozhang Wang commented on KAFKA-10410:
---------------------------------------

Not sure if I fully understand what do you mean by "GlobalStateRestoreListener 
have a way of obtaining StateRestoreCallback", but just to clarify, the 
"StateRestoreListener" is used for notifying when a restoration is started / 
ended etc, and the "StateRestoreCallback" is for the actual implementation of 
applying the changelog records to the state stores, and they should naturally 
be in two separate implementations:

1) You specify the per-store "StateRestoreCallback" when you register a store.
2) You specify the global "StateRestoreListener" when you instantiate a streams 
instance.

We do not recommend having just one impl class that extends both interfaces 
moving forward.

If you can share your current code maybe that can help me better understanding 
your pattern.

> OnRestoreStart disappeared from StateRestoreCallback  in 2.6.0 and reappeared 
> in a useless place
> ------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-10410
>                 URL: https://issues.apache.org/jira/browse/KAFKA-10410
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 2.6.0
>            Reporter: Mark Shelton
>            Priority: Blocker
>
> In version 2.5.0 and earlier there are "onRestoreStart" and "onRestoreEnd" 
> methods on StateRestoreCallback.
> Version 2.6.0 removed these calls and put them into StateRestoreListener and 
> requires "streaming.setGlobalStateRestoreListener".
> This makes it impossible for the actual StateRestoreCallback implementation 
> to receive the start and end indication and is blocking me from moving to 
> 2.6.0.
> See:
> [https://kafka.apache.org/25/javadoc/index.html?org/apache/kafka/streams/processor/AbstractNotifyingRestoreCallback.html]
>  
> Related JIRA:
> https://issues.apache.org/jira/browse/KAFKA-4322 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to