[
https://issues.apache.org/jira/browse/KAFKA-10410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186019#comment-17186019
]
Guozhang Wang commented on KAFKA-10410:
---------------------------------------
Thanks Mark for your explanation. I think for metrics recording since the
callbacks contain the partition / store-name information it can be done
independently from the callback. For transaction / cleanup, it depends on your
specific scenarios, but if it has to couple with the callbacks one way like
Sophie mentioned is to let the global listener keeps reference of each callback
that ever gets created / registered --- admittedly it is a bit awkward, but it
should work around it.
> OnRestoreStart disappeared from StateRestoreCallback in 2.6.0 and reappeared
> in a useless place
> ------------------------------------------------------------------------------------------------
>
> Key: KAFKA-10410
> URL: https://issues.apache.org/jira/browse/KAFKA-10410
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Affects Versions: 2.6.0
> Reporter: Mark Shelton
> Priority: Blocker
>
> In version 2.5.0 and earlier there are "onRestoreStart" and "onRestoreEnd"
> methods on StateRestoreCallback.
> Version 2.6.0 removed these calls and put them into StateRestoreListener and
> requires "streaming.setGlobalStateRestoreListener".
> This makes it impossible for the actual StateRestoreCallback implementation
> to receive the start and end indication and is blocking me from moving to
> 2.6.0.
> See:
> [https://kafka.apache.org/25/javadoc/index.html?org/apache/kafka/streams/processor/AbstractNotifyingRestoreCallback.html]
>
> Related JIRA:
> https://issues.apache.org/jira/browse/KAFKA-4322
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
