[GitHub] [kafka] ableegoldman commented on a change in pull request #9138: KAFKA-9929: Support backward iterator on WindowStore

[GitBox]

ableegoldman commented on a change in pull request #9138:
URL: https://github.com/apache/kafka/pull/9138#discussion_r478769493



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractWindowBytesStoreTest.java
##########
@@ -287,17 +308,43 @@ public void shouldFetchAllInTimeRange() {
         final KeyValue<Windowed<Integer>, String> four = windowedPair(4, 
"four", startTime + 4);
         final KeyValue<Windowed<Integer>, String> five = windowedPair(5, 
"five", startTime + 5);
 
-        assertEquals(
-            new HashSet<>(asList(one, two, four)),
-            toSet(windowStore.fetchAll(ofEpochMilli(startTime + 1), 
ofEpochMilli(startTime + 4)))
+        assertArrayEquals(
+            new LinkedHashSet<>(asList(one, two, four)).toArray(),
+            toSet(windowStore.fetchAll(ofEpochMilli(startTime + 1), 
ofEpochMilli(startTime + 4))).toArray()
         );
-        assertEquals(
-            new HashSet<>(asList(zero, one, two)),
-            toSet(windowStore.fetchAll(ofEpochMilli(startTime + 0), 
ofEpochMilli(startTime + 3)))
+        assertArrayEquals(
+            new LinkedHashSet<>(asList(zero, one, two)).toArray(),
+            toSet(windowStore.fetchAll(ofEpochMilli(startTime + 0), 
ofEpochMilli(startTime + 3))).toArray()
         );
-        assertEquals(
-            new HashSet<>(asList(one, two, four, five)),
-            toSet(windowStore.fetchAll(ofEpochMilli(startTime + 1), 
ofEpochMilli(startTime + 5)))
+        assertArrayEquals(
+            new LinkedHashSet<>(asList(one, two, four, five)).toArray(),

Review comment:
       Haha actually I think I was the one who added the initial conversion 
from list to set to begin with, so I was clearly asking for trouble




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org