ableegoldman commented on a change in pull request #9138:
URL: https://github.com/apache/kafka/pull/9138#discussion_r480479677
##########
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/CachingWindowStore.java
##########
@@ -271,27 +345,68 @@ public synchronized void put(final Bytes key,
final PeekingKeyValueIterator<Bytes, LRUCacheEntry>
filteredCacheIterator =
new FilteredCacheIterator(cacheIterator, hasNextCondition,
cacheFunction);
return new MergedSortedCacheWindowStoreKeyValueIterator(
- filteredCacheIterator,
- underlyingIterator,
- bytesSerdes,
- windowSize,
- cacheFunction
+ filteredCacheIterator,
+ underlyingIterator,
+ bytesSerdes,
+ windowSize,
+ cacheFunction,
+ true
+ );
+ }
+
+ @Override
+ public KeyValueIterator<Windowed<Bytes>, byte[]> backwardFetchAll(final
long timeFrom,
Review comment:
We would still need to keep this method: we're not removing all
long-based APIs, just the public/IQ methods in ReadOnlyWindowStore. But we
still want to keep the long-based methods on WindowStore and all the internal
store interfaces for performance reasons.
Maybe once we move everything to use `Instant` all the way down to the
serialization then we can remove these long-based methods. I guess we should
consider that when discussing KIP-667, but for the time being at least, we
should keep them for internal use
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
