guozhangwang commented on a change in pull request #8834:
URL: https://github.com/apache/kafka/pull/8834#discussion_r485326873
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##########
@@ -652,10 +644,10 @@ public void handle(JoinGroupResponse joinResponse,
RequestFuture<ByteBuffer> fut
} else if (error == Errors.MEMBER_ID_REQUIRED) {
// Broker requires a concrete member id to be allowed to join
the group. Update member id
// and send another join group request in next cycle.
+ String memberId = joinResponse.data().memberId();
+ log.debug("Attempt to join group returned {} error. Will set
the member id as {} and then rejoin", error, memberId);
synchronized (AbstractCoordinator.this) {
- AbstractCoordinator.this.generation = new
Generation(OffsetCommitRequest.DEFAULT_GENERATION_ID,
- joinResponse.data().memberId(), null);
- AbstractCoordinator.this.resetStateAndRejoin();
Review comment:
Yes, this is redundant since we are raising this error and
`resetStateAndRejoin()` would still be executed at the handler anyways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
