vvcephei commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r487988227
########## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignmentInfo.java ########## @@ -186,6 +186,15 @@ public ByteBuffer encode() { out.writeInt(errCode); out.writeLong(nextRebalanceMs); break; + case 8: + out.writeInt(usedVersion); + out.writeInt(commonlySupportedVersion); + encodeActiveAndStandbyTaskAssignment(out); + encodeActiveAndStandbyHostPartitions(out); + out.writeInt(errCode); + out.writeLong(nextRebalanceMs); + out.writeInt(0); Review comment: Cool. Yes, they have different schemas. SubscriptionInfo has been migrated to use an explicit schema, while AssignmentInfo still uses hand-coded de/serialization code. Never got around to migrating AssignmentInfo. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org