hachikuji commented on a change in pull request #9311:
URL: https://github.com/apache/kafka/pull/9311#discussion_r501168361
##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -2336,6 +2335,11 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ def maybeReturnOldClientError(error: Errors, requestVersion: Short): Boolean
= {
+ requestVersion < 2 && (error == Errors.PRODUCER_FENCED || error == Errors
Review comment:
We need to bump the protocol versions for the new error code. Otherwise
older clients using version 2 will not know how to handle
`TRANSACTION_TIMED_OUT` and will translate it to `UNKNOWN_SERVER_ERROR`, which
is a regression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
