abbccdda commented on a change in pull request #9311:
URL: https://github.com/apache/kafka/pull/9311#discussion_r502818179
##########
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##########
@@ -2083,8 +2083,8 @@ class KafkaApis(val requestChannel: RequestChannel,
def sendResponseCallback(error: Errors): Unit = {
def createResponse(requestThrottleMs: Int): AbstractResponse = {
val finalError =
- if (endTxnRequest.version < 2 && error == Errors.PRODUCER_FENCED) {
- // For older clients, they could not understand the new
PRODUCER_FENCED error code,
+ if (maybeReturnOldClientError(error, endTxnRequest.version)) {
Review comment:
I see your pt, we could get rid of the helper.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
