vvcephei commented on pull request #9414: URL: https://github.com/apache/kafka/pull/9414#issuecomment-707271073
Thanks for the PR, @dongjinleekr ! Just a couple of meta-questions: 1. Should we have some tests for this change? 2. I think that right now, we'd be leaving behind some task directories and lock files. Maybe, we need to do a little extra legwork to recursively delete the app state directory. An integration test would probably surface this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org