Lincong commented on pull request #9435:
URL: https://github.com/apache/kafka/pull/9435#issuecomment-708650004


   @ijuma One way to test it could be to mock objects passed to the `KafkaApis` 
class. The `MetadataCache` object should be mocked in a way that upon the first 
invocation on the method `getAllTopics` to simulate the scenario in which the 
metadata cache got updated "concurrently" with `handleTopicMetadataRequest`.
   
   However, IMO, this change is pretty minor. So, I am wondering how necessary 
it is to add tests for it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to