[
https://issues.apache.org/jira/browse/KAFKA-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-10628:
---------------------------------
Assignee: Luke Chen
> Follow-up: Remove all unnecessary dummy TopologyTestDriver configs
> ------------------------------------------------------------------
>
> Key: KAFKA-10628
> URL: https://issues.apache.org/jira/browse/KAFKA-10628
> Project: Kafka
> Issue Type: Task
> Components: streams, streams-test-utils
> Reporter: John Roesler
> Assignee: Luke Chen
> Priority: Minor
> Labels: newbie
>
> After [https://github.com/apache/kafka/pull/9477,] we no longer need to
> specify dummy values for bootstrap servers and application id when creating a
> TopologyTestDriver.
>
> This task is to track down all those unnecessary parameters and delete them.
> You can consult the above pull request for some examples of this.
>
> Note that there are times when the application id is actually significant,
> since it is used in conjunction with the state directory to give the driver a
> unique place to store local state. On the other hand, it would be sufficient
> to just set a unique state directory and not bother with the app id in that
> case.
>
> During review, [~chia7712] pointed out that this comment
> ([https://github.com/apache/kafka/blob/trunk/streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java#L138])
> can be removed since it is not necessary anymore. (It's the mention of the
> dummy params from the javadoc of the TopologyTestDriver)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
