[GitHub] [kafka] wcarlson5 commented on a change in pull request #9583: MINOR: Make state stores not readable by others

[GitBox]

wcarlson5 commented on a change in pull request #9583:
URL: https://github.com/apache/kafka/pull/9583#discussion_r520710986



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##########
@@ -102,6 +107,13 @@ public StateDirectory(final StreamsConfig config, final 
Time time, final boolean
             log.warn("Using /tmp directory in the state.dir property can cause 
failures with writing the checkpoint file" +
                 " due to the fact that this directory can be cleared by the 
OS");
         }
+        final Path path = Paths.get(baseDir.getPath());

Review comment:
       Is changing the `baseDir` sufficient?

##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##########
@@ -30,11 +30,16 @@
 import java.nio.channels.FileChannel;
 import java.nio.channels.FileLock;
 import java.nio.channels.OverlappingFileLockException;
-import java.nio.file.NoSuchFileException;

Review comment:
       Did we need to move this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org