lct45 commented on a change in pull request #9583:
URL: https://github.com/apache/kafka/pull/9583#discussion_r520723720
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##########
@@ -102,6 +107,13 @@ public StateDirectory(final StreamsConfig config, final
Time time, final boolean
log.warn("Using /tmp directory in the state.dir property can cause
failures with writing the checkpoint file" +
" due to the fact that this directory can be cleared by the
OS");
}
+ final Path path = Paths.get(baseDir.getPath());
Review comment:
It should be, the `stateDir` is inside of the `baseDir` so the
permissions should apply there as well. I guess if we wanted to be _more_
selective we could apply permissions to `stateDir` and not `baseDir` but from
what I see it doesn't make a big difference. In the test though, there is an
`appDir` that had broader permissions even with the changes to `baseDir` so
maybe we _do_ need to change permissions to both `baseDir` and `stateDir`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
