mjsax commented on a change in pull request #8965:
URL: https://github.com/apache/kafka/pull/8965#discussion_r525425175
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -120,6 +120,11 @@ <h3><a id="streams_api_changes_260"
href="#streams_api_changes_260">Streams API
We added a <code>--force</code> option in StreamsResetter to force
remove left-over members on broker side when long session time out was
configured
as per <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-571%3A+Add+option+to+force+remove+members+in+StreamsResetter";>KIP-571</a>.
</p>
+ <p>
+ We added a <code>Suppressed.withLoggingDisabled()</code> and
<code>Suppressed.withLoggingEnabled(config)</code>
+ method to disables (no s) and allows for configuration of the
changelog topic
Review comment:
`method[s]` (plural)
`to disables (no s)...` -> `to allow disabling or configuring of the
changelog topic`
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -120,6 +120,11 @@ <h3><a id="streams_api_changes_260"
href="#streams_api_changes_260">Streams API
We added a <code>--force</code> option in StreamsResetter to force
remove left-over members on broker side when long session time out was
configured
as per <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-571%3A+Add+option+to+force+remove+members+in+StreamsResetter";>KIP-571</a>.
</p>
+ <p>
+ We added a <code>Suppressed.withLoggingDisabled()</code> and
<code>Suppressed.withLoggingEnabled(config)</code>
Review comment:
just `We added <code>` (no `a`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
