showuon commented on a change in pull request #9629:
URL: https://github.com/apache/kafka/pull/9629#discussion_r527495985
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/StreamsUncaughtExceptionHandlerIntegrationTest.java
##########
@@ -145,48 +142,12 @@ public void shouldShutdownClient() throws Exception {
@Test
public void shouldShutdownApplication() throws Exception {
- final Topology topology = builder.build();
-
- try (final KafkaStreams kafkaStreams = new KafkaStreams(topology,
properties)) {
- final KafkaStreams kafkaStreams1 = new KafkaStreams(topology,
properties);
- final CountDownLatch latch = new CountDownLatch(1);
- kafkaStreams.setUncaughtExceptionHandler((t, e) -> fail("should
not hit old handler"));
- kafkaStreams1.setUncaughtExceptionHandler((t, e) -> fail("should
not hit old handler"));
- kafkaStreams.setUncaughtExceptionHandler(exception ->
SHUTDOWN_APPLICATION);
- kafkaStreams1.setUncaughtExceptionHandler(exception ->
SHUTDOWN_APPLICATION);
-
- kafkaStreams.start();
- kafkaStreams1.start();
Review comment:
The start is async, and we didn't wait for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
