showuon commented on a change in pull request #9629:
URL: https://github.com/apache/kafka/pull/9629#discussion_r527720582
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java
##########
@@ -903,16 +903,19 @@ public static void
startApplicationAndWaitUntilRunning(final List<KafkaStreams>
}
/**
- * Waits for the given {@link KafkaStreams} instances to all be in a
{@link State#RUNNING}
- * state. Prefer {@link #startApplicationAndWaitUntilRunning(List,
Duration)} when possible
+ * Waits for the given {@link KafkaStreams} instances to all be in a
specific {@link State}.
+ * Prefer {@link #startApplicationAndWaitUntilRunning(List, Duration)}
when possible
* because this method uses polling, which can be more error prone and
slightly slower.
*
* @param streamsList the list of streams instances to run.
- * @param timeout the time to wait for the streams to all be in {@link
State#RUNNING} state.
+ * @param state the expected state that all the streams to be in within
timeout
+ * @param timeout the time to wait for the streams to all be in the
specific state.
+ *
+ * @throws InterruptedException if the streams doesn't change to the
expected state in time.
*/
public static void waitForApplicationState(final List<KafkaStreams>
streamsList,
final State state,
- final Duration timeout) throws
Exception {
+ final Duration timeout) throws
InterruptedException {
Review comment:
We should throw a specific kind of exception, not an `Exception`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
