mimaison commented on pull request #9701: URL: https://github.com/apache/kafka/pull/9701#issuecomment-739529552
I don't think it's enough. The `bootstrap.servers` documentation says: > This list should be in the form host1:port1,host2:port2,.... But clients also accept `protocol://host:port` even if they don't use the protocol. It looks like this was not really expected as there are no tests validating this. As it's unused the protocol could be anything and contains any characters. For example, a client with the following works: ``` config.put(CommonClientConfigs.BOOTSTRAP_SERVERS_CONFIG, "WH4T#$@VER¾://localhost:9092"); ``` So if a protocol is specified, we should allow any characters. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
