tombentley commented on pull request #9701: URL: https://github.com/apache/kafka/pull/9701#issuecomment-739816502
OK, but then we either: 1. Make it literally any character, and mark KAFKA-10713 as won't fix, or 2. Make it any character except `;`, in order to prevent KAFKA-10713, or 3. Fix the parsing to be as documented, disallowing any protocol for the broker's `bootstrap.servers`, streams' `application.server`, and the raft `quorum.voters`. It seems that the protocol was first added in 53f31432a0e1da78abf31ad42297790445083072 (part of https://cwiki.apache.org/confluence/display/KAFKA/Multiple+Listeners+for+Kafka+Brokers), but it's not really clear why it was allowed for client configs. While option 2 is easiest, I feel that 3 is closer to the right thing to do: Having documentation and implementation aligned will prevent other possible errors people might make, especially as this code is slowly being reused for other configs. Thoughts? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
