hachikuji commented on a change in pull request #9732:
URL: https://github.com/apache/kafka/pull/9732#discussion_r543561935
##########
File path: core/src/main/scala/kafka/raft/KafkaNetworkChannel.scala
##########
@@ -53,6 +54,41 @@ object KafkaNetworkChannel {
}
+private[raft] class RaftSendThread(
Review comment:
Not really as far as I know. This is my favored style of late because it
results in consistent alignment of parameters. I get really annoyed when I see
stuff like this:
```
def someMethodWithAnArguablyOverVerboseName(foo: String,
bar: Option[List[Int]]):
(Option[String], List[String)
def concicseMethod(foo: String,
bar: String): Unit = {
```
No matter how you look at it, it seems hideous.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
