hachikuji commented on a change in pull request #9732:
URL: https://github.com/apache/kafka/pull/9732#discussion_r543567541
##########
File path:
core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerChannelManager.scala
##########
@@ -127,11 +127,14 @@ class TxnMarkerQueue(@volatile var destination: Node) {
def totalNumMarkers(txnTopicPartition: Int): Int =
markersPerTxnTopicPartition.get(txnTopicPartition).fold(0)(_.size)
}
-class TransactionMarkerChannelManager(config: KafkaConfig,
- metadataCache: MetadataCache,
- networkClient: NetworkClient,
- txnStateManager: TransactionStateManager,
- time: Time) extends
InterBrokerSendThread("TxnMarkerSenderThread-" + config.brokerId,
networkClient, time) with Logging with KafkaMetricsGroup {
+class TransactionMarkerChannelManager(
Review comment:
That's fair. I actually held myself back. I tried to only touch the
cases that I was modifying anyway, but let me know if there are others. This
one was especially obnoxious because of the long parameter list to
`InterBrokerSendThread`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
