g1geordie commented on a change in pull request #9778:
URL: https://github.com/apache/kafka/pull/9778#discussion_r551467279
##########
File path: core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala
##########
@@ -212,7 +214,9 @@ class ClientQuotasRequestTest extends BaseRequestTest {
InetAddress.getByName(unknownHost)
else
InetAddress.getByName(entityName)
- assertEquals(expectedMatches(entity),
servers.head.socketServer.connectionQuotas.connectionRateForIp(entityIp), 0.01)
+ TestUtils.waitUntilTrue(
+ () => expectedMatches(entity) -
servers.head.socketServer.connectionQuotas.connectionRateForIp(entityIp) < 0.01
+ ,"Broker didn't update quotas from Zookeeper")
Review comment:
@dajac
hello~
I remain the message `Broker didn't update quotas from Zookeeper` which
clearly indicate the error.
And add `expect` and `got` to error message
Can you help me take a look again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
