dajac commented on a change in pull request #9778:
URL: https://github.com/apache/kafka/pull/9778#discussion_r552704458
##########
File path: core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala
##########
@@ -212,7 +214,9 @@ class ClientQuotasRequestTest extends BaseRequestTest {
InetAddress.getByName(unknownHost)
else
InetAddress.getByName(entityName)
- assertEquals(expectedMatches(entity),
servers.head.socketServer.connectionQuotas.connectionRateForIp(entityIp), 0.01)
+ TestUtils.waitUntilTrue(
+ () => expectedMatches(entity) -
servers.head.socketServer.connectionQuotas.connectionRateForIp(entityIp) < 0.01
+ ,"Broker didn't update quotas from Zookeeper")
Review comment:
Thanks for the update. I think that we should not mention ZK here as ZK
is going away. How about `Connection quota of $entity is not $expected but
$actual`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
