jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r555991729
##########
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##########
@@ -272,26 +272,29 @@ private void onUpdateLeaderHighWatermark(
// It is also possible that the high watermark is being updated
// for the first time following the leader election, so we need
// to give lagging listeners an opportunity to catch up as well
- maybeFireHandleCommit(highWatermark.offset);
+ onHighWatermarkUpdated(highWatermark.offset);
});
}
- private void maybeFireHandleCommit(long highWatermark) {
- maybeFireHandleCommit(listenerContexts, highWatermark);
+ private void onHighWatermarkUpdated(long highWatermark) {
+ onHighWatermarkUpdated(listenerContexts, highWatermark);
}
- private void maybeFireHandleCommit(List<ListenerContext> listenerContexts,
long highWatermark) {
+ private void onHighWatermarkUpdated(List<ListenerContext>
listenerContexts, long highWatermark) {
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
