jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r557033870
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -1314,11 +1318,24 @@ class Log(@volatile private var _dir: File,
/**
* Increment the log start offset if the provided offset is larger.
+ *
+ * If the log start offset changed, then this method:
+ *
+ * 1. Records the new log start offset.
+ * 2. Updates the high watermark if it is less than the new log start offset
Review comment:
Yeah, I agree. I originally decided to add a comment because it was
educational to me when I discovered that this call updated a few other
components. I changed the documentation to be a bit more high-level and less
likely to change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
