abbccdda commented on a change in pull request #9600:
URL: https://github.com/apache/kafka/pull/9600#discussion_r556245337
##########
File path:
clients/src/main/java/org/apache/kafka/common/protocol/ApiVersion.java
##########
@@ -53,4 +53,18 @@ public String toString() {
", maxVersion= " + maxVersion +
")";
}
+
+ public static ApiVersion versionsInCommon(ApiKeys apiKey, ApiVersion
supportedVersions,
Review comment:
I looked up the usage of this API, it has the external effect to have
reference `min` and `max` versions. At least the current format is the most
straightforward refactoring without the need to create another `ApiVersion`
instance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
