abbccdda commented on a change in pull request #9600:
URL: https://github.com/apache/kafka/pull/9600#discussion_r557823644
##########
File path: core/src/main/scala/kafka/server/ForwardingManager.scala
##########
@@ -77,7 +79,7 @@ class ForwardingManagerImpl(
override def forwardRequest(
request: RequestChannel.Request,
- responseCallback: AbstractResponse => Unit
+ responseCallback: Either[AbstractResponse, Errors] => Unit
Review comment:
I'm inclined to keep it as it is, since the current return type gives
caller a root cause message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
