[GitHub] [kafka] aloknnikhil commented on a change in pull request #9881: MINOR: Initialize QuorumState lazily in RaftClient.initialize()

[GitBox]

aloknnikhil commented on a change in pull request #9881:
URL: https://github.com/apache/kafka/pull/9881#discussion_r557574380



##########
File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java
##########
@@ -129,16 +133,41 @@ public String toString() {
                 QUORUM_LINGER_MS_DOC);
     }
 
+    private final int requestTimeoutMs;
+    private final int retryBackoffMs;
+    private final int electionTimeoutMs;
+    private final int electionBackoffMaxMs;
+    private final int fetchTimeoutMs;
+    private final int appendLingerMs;
+
     public RaftConfig(Properties props) {
         super(CONFIG, props);
+        requestTimeoutMs = getInt(QUORUM_REQUEST_TIMEOUT_MS_CONFIG);
+        retryBackoffMs = getInt(QUORUM_RETRY_BACKOFF_MS_CONFIG);
+        electionTimeoutMs = getInt(QUORUM_ELECTION_TIMEOUT_MS_CONFIG);
+        electionBackoffMaxMs = getInt(QUORUM_ELECTION_BACKOFF_MAX_MS_CONFIG);
+        fetchTimeoutMs = getInt(QUORUM_FETCH_TIMEOUT_MS_CONFIG);
+        appendLingerMs = getInt(QUORUM_LINGER_MS_CONFIG);
     }
 
-    public RaftConfig(Map<String, Object> props) {
+    public RaftConfig(Map<?, ?> props) {
         super(CONFIG, props);
+        requestTimeoutMs = getInt(QUORUM_REQUEST_TIMEOUT_MS_CONFIG);

Review comment:
       Actually, that means I can remove the `public RaftConfig(Properties 
props)` constructor. Does that make sense @hachikuji?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org