[GitHub] [kafka] jsancio commented on a change in pull request #9881: MINOR: Initialize QuorumState lazily in RaftClient.initialize()

[GitBox]

jsancio commented on a change in pull request #9881:
URL: https://github.com/apache/kafka/pull/9881#discussion_r558601210



##########
File path: core/src/main/scala/kafka/raft/RaftManager.scala
##########
@@ -168,30 +166,20 @@ class KafkaRaftManager[T](
   }
 
   private def buildRaftClient(): KafkaRaftClient[T] = {
-    val quorumState = new QuorumState(
-      nodeId,
-      raftConfig.quorumVoterIds,
-      raftConfig.electionTimeoutMs,
-      raftConfig.fetchTimeoutMs,
-      new FileBasedStateStore(new File(dataDir, "quorum-state")),
-      time,
-      logContext,
-      new Random()
-    )
 
     val expirationTimer = new SystemTimer("raft-expiration-executor")
     val expirationService = new TimingWheelExpirationService(expirationTimer)
 
     new KafkaRaftClient(
-      raftConfig,
       recordSerde,
       netChannel,
       metadataLog,
-      quorumState,
+      new FileBasedStateStore(new File(dataDir, "quorum-state")),

Review comment:
       This is a really important file name and should be stored and documented 
in a static final field. How about defining this in `FileBasedStateStore` and 
changing the constructor to `FileBasedStateStore(Path dataDir)`?
   
   If you agree, I can file an issue for this.
   
   cc @aloknnikhil @hachikuji 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org