vvcephei commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-761683902
Hey @inponomarev , I just took a look at the Scala API. Thanks for adding that! I figured it'd be just easier to push a few tweaks than to describe what needs to be done. * You asked me offline if we could avoid the overloads in Branched, and indeed, we can with a default argument of `null` for the name. * The Scala test was inadvertently using the Java Branched class, but you meant to test the Scala one. * I happened to notice a small typo: The opposite of "prefix" is "suffix", not "postfix" * I also noticed that your files all had CRLF (windows) return characters, so I fixed them. You might want to configure git for `autocrlf` (`git config --global core.autocrlf true`) (see https://www.git-scm.com/book/en/v2/Customizing-Git-Git-Configuration) These are all separate commits above, so you can scrutinize each one. This PR is your work, so feel free to protest any of my suggestions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
