vvcephei commented on pull request #9107: URL: https://github.com/apache/kafka/pull/9107#issuecomment-762918424
Thanks @inponomarev , Ah, I didn't notice that method signature name. I actually prefer it this way :) Thanks also for pointing out the covariance change. This is also fine. Java's type system only contains a partial implementation of variance, so we do best we can. Did you already update the KIP? If not, please do. I'm +1 on this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
