g1geordie commented on a change in pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#discussion_r559873989
##########
File path:
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsBuilderTest.java
##########
@@ -72,19 +70,28 @@ public String toString() {
List<Arguments> values = new ArrayList<>();
for (int bufferOffset : Arrays.asList(0, 15))
for (CompressionType compressionType :
CompressionType.values())
- values.add(Arguments.of(new Args(bufferOffset,
compressionType)));
+ if (accept(compressionType))
+ values.add(Arguments.of(new Args(bufferOffset,
compressionType)));
return values.stream();
}
+ protected boolean accept(CompressionType type) {
+ return true;
+ }
+ }
+
+ private static class NotZstd extends MemoryRecordsBuilderArgumentsProvider
{
Review comment:
Let me explain
The annotation `@RecordSource` supply valid `( compress , magic )` mapping
from magic .
If minMaigc or maxMaigc is set , it will retrun valid `(compress , magic in
range)` and symbolize the test test in what version more clearly .
I don't know this style for both of you is more meaningful or complex.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
