chia7712 commented on a change in pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#discussion_r559933397
##########
File path:
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsBuilderTest.java
##########
@@ -72,19 +70,28 @@ public String toString() {
List<Arguments> values = new ArrayList<>();
for (int bufferOffset : Arrays.asList(0, 15))
for (CompressionType compressionType :
CompressionType.values())
- values.add(Arguments.of(new Args(bufferOffset,
compressionType)));
+ if (accept(compressionType))
+ values.add(Arguments.of(new Args(bufferOffset,
compressionType)));
return values.stream();
}
+ protected boolean accept(CompressionType type) {
+ return true;
+ }
+ }
+
+ private static class NotZstd extends MemoryRecordsBuilderArgumentsProvider
{
Review comment:
My point was ```haveInvalidCompress``` is hard to understand which
compression is invalid. In current test cases, only zstd is possible to be
excluded, right? If so, the name like "NotZstd" is more readable to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
