wcarlson5 commented on a change in pull request #9720:
URL: https://github.com/apache/kafka/pull/9720#discussion_r560529803
##########
File path:
streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java
##########
@@ -113,14 +114,7 @@
private static final List<KeyValue<KafkaStreams.State,
KafkaStreams.State>> CRASH =
Collections.unmodifiableList(
Collections.singletonList(
- KeyValue.pair(KafkaStreams.State.RUNNING,
KafkaStreams.State.ERROR)
- )
- );
- private static final List<KeyValue<KafkaStreams.State,
KafkaStreams.State>> CLOSE_CRASHED =
- Collections.unmodifiableList(
- Arrays.asList(
- KeyValue.pair(KafkaStreams.State.ERROR,
KafkaStreams.State.PENDING_SHUTDOWN),
- KeyValue.pair(KafkaStreams.State.PENDING_SHUTDOWN,
KafkaStreams.State.NOT_RUNNING)
+ KeyValue.pair(State.PENDING_ERROR, State.ERROR)
Review comment:
Using just `PENDING_ERROR -> ERROR` because the transition to
`PENDING_ERROR` can be from multiple sources. Also that transition is already
tested so this check implies it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
